Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add l2_loss function to tensorflow frontend #23073

Closed
wants to merge 2 commits into from
Closed

add l2_loss function to tensorflow frontend #23073

wants to merge 2 commits into from

Conversation

0StevenH0
Copy link

@0StevenH0 0StevenH0 commented Sep 5, 2023 •
edited
Loading

PR Description

  • Added l2_loss function at ivy/experimental/nn.py
  • Added l2_loss function at tensorflow frontend
  • Added l2_loss test

Related

Close #23073

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request labels Sep 5, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@0StevenH0 0StevenH0 marked this pull request as draft September 6, 2023 07:23
This was referenced Sep 6, 2023
Open
Closed
@ivy-leaves ivy-leaves added the Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards label Sep 6, 2023
@AnnaTz AnnaTz mentioned this pull request Sep 6, 2023
Merged
Ishticode
Ishticode reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0StevenH0
Thanks for the PR. :)
This PR has been marked draft for 6 months with no activity.
Is this still being worked upon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishticode Ishticode Ishticode left review comments

Assignees

@Ishticode Ishticode

Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0StevenH0 @ivy-leaves @Ishticode @paulaehab @Sam-Armstrong